treeview: Don't create a cyclic reference
authorBenjamin Otte <otte@redhat.com>
Sun, 8 Dec 2019 05:26:26 +0000 (06:26 +0100)
committerBenjamin Otte <otte@redhat.com>
Mon, 9 Dec 2019 15:35:41 +0000 (16:35 +0100)
TreeRowReference refs the proxy object, so don't use proxies.

gtk/gtktreeview.c

index 647d2e14404bd929d0b3113c9489f6a7dfd8675b..4c51ba451ef5ceac794e9894917f0f165129ef60 100644 (file)
@@ -3760,10 +3760,8 @@ gtk_tree_view_stop_rubber_band (GtkTreeView *tree_view)
           if (tree_view->priv->anchor)
             gtk_tree_row_reference_free (tree_view->priv->anchor);
 
-          tree_view->priv->anchor =
-            gtk_tree_row_reference_new_proxy (G_OBJECT (tree_view),
-                                              tree_view->priv->model,
-                                              tmp_path);
+          tree_view->priv->anchor = gtk_tree_row_reference_new (tree_view->priv->model,
+                                                                tmp_path);
 
           gtk_tree_path_free (tmp_path);
         }
@@ -9341,8 +9339,7 @@ _gtk_tree_view_set_anchor_path (GtkTreeView *tree_view,
 
   if (anchor_path && tree_view->priv->model)
     tree_view->priv->anchor =
-      gtk_tree_row_reference_new_proxy (G_OBJECT (tree_view), 
-                                       tree_view->priv->model, anchor_path);
+      gtk_tree_row_reference_new (tree_view->priv->model, anchor_path);
 }
 
 GtkTreeRBTree *